Repository navigation
fix(networkx): accept a callable relabel_nodes mapping - #16552
Merged
Merged
Conversation
NetworkX calls a function mapping for every node. The stub only allowed Mapping, so that documented call did not type-check.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16545
Why
NetworkX calls a function mapping once for every node. The stub only allowed a mapping, so that documented call did not type-check.
What changed
relabel_nodesaccepts a mapping or a function from the old node to the new node.Scope
This covers the four graph overloads. The return type stays the same. Other open networkx stub pull requests are left alone.
Verification
mypy 2.4.0 rejected
Callable[[int], int]and a lambda before this change, and accepts both after it. Anintis still rejected. NetworkX 3.6.1 runs the documented lambda and returns[0, 1, 4].Upstream: https://github.com/networkx/networkx/blob/networkx-3.6.1/networkx/relabel.py#L67-L122
Cursor
Drafted with Cursor.